Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] Add Support for Lucene Byte Sized Vector (#971) #974

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

naveentatikonda
Copy link
Member

Description

(cherry picked from commit bf04854)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Add Indexing Support for Lucene Byte Sized Vector (#937)

* Add Indexing Support for Lucene Byte Sized Vector

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add tests for Indexing

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add CHANGELOG

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add Querying Support to Lucene Byte Sized Vector (#956)

* Add Querying Support to Lucene Byte Sized Vector

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add CHANGELOG

Signed-off-by: Naveen Tatikonda <[email protected]>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>

* Add DocValues Support for Lucene Byte Sized Vector (#953)

Signed-off-by: Naveen Tatikonda <[email protected]>

* Update Release Notes

Signed-off-by: Naveen Tatikonda <[email protected]>

---------

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit bf04854)
Signed-off-by: Naveen Tatikonda <[email protected]>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #974 (f71e5ee) into 2.9 (86b812c) will increase coverage by 0.11%.
The diff coverage is 86.61%.

@@             Coverage Diff              @@
##                2.9     #974      +/-   ##
============================================
+ Coverage     85.05%   85.16%   +0.11%     
- Complexity     1116     1145      +29     
============================================
  Files           152      154       +2     
  Lines          4530     4693     +163     
  Branches        409      426      +17     
============================================
+ Hits           3853     3997     +144     
- Misses          492      504      +12     
- Partials        185      192       +7     
Impacted Files Coverage Δ
...opensearch/knn/index/mapper/LuceneFieldMapper.java 71.15% <64.00%> (-3.27%) ⬇️
...ain/java/org/opensearch/knn/index/VectorField.java 71.42% <66.66%> (-3.58%) ⬇️
...nsearch/knn/index/mapper/KNNVectorFieldMapper.java 82.93% <79.41%> (-0.88%) ⬇️
...rg/opensearch/knn/index/query/KNNQueryFactory.java 88.13% <85.00%> (-2.35%) ⬇️
...rch/knn/index/mapper/KNNVectorFieldMapperUtil.java 90.47% <90.47%> (ø)
...n/java/org/opensearch/knn/common/KNNConstants.java 93.75% <100.00%> (+0.41%) ⬆️
...opensearch/knn/index/KNNVectorDVLeafFieldData.java 75.00% <100.00%> (+2.27%) ⬆️
.../opensearch/knn/index/KNNVectorIndexFieldData.java 100.00% <100.00%> (ø)
...opensearch/knn/index/KNNVectorScriptDocValues.java 84.61% <100.00%> (-5.87%) ⬇️
.../java/org/opensearch/knn/index/VectorDataType.java 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@naveentatikonda naveentatikonda merged commit 581fadd into 2.9 Jul 12, 2023
54 of 58 checks passed
@github-actions github-actions bot deleted the backport/backport-971-to-2.9 branch July 12, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants